Remove wal_level settings for subscribers in tap tests

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Remove wal_level settings for subscribers in tap tests
Date: 2023-10-18 02:59:52
Message-ID: TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear hackers,

While discussing [1], I found that in tap tests, wal_level was set to logical for
subscribers too. The setting is not needed for subscriber side, and it may cause
misunderstanding for newcomers. Therefore, I wanted to propose the patch which
removes unnecessary "allows_streaming => 'logical'".
I grepped with the string and checked the necessity of them one by one.

How do you think?

[1]: https://commitfest.postgresql.org/45/4273/

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
0001-remove-unnecessary-wal_level-settings.patch application/octet-stream 19.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-10-18 03:15:14 Re: Add support for AT LOCAL
Previous Message Stephen Frost 2023-10-18 02:52:05 Re: [PoC/RFC] Multiple passwords, interval expirations