| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Subject: | PGdoc: add missing ID attribute to create_subscription.sgml |
| Date: | 2023-03-23 06:22:03 |
| Message-ID: | TYAPR01MB58667AE04D291924671E2051F5879@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear hackers, (CC: reviewers of copy-binary patch)
This is an follow-up thread of [1]. PSA patch that adds an attributes.
By ecb6965, an XML ID attribute is added only one varlistentry in create_subscription.sgml.
But according to the commit 78ee60 and related discussions [2], [3], it is worth
adding ID attribute to other entries. This patch adds them.
Moreover, I have added some references to parameters from pre-existing documents.
Only entries that are referred from other files have XREFLABEL attribute.
Basically I detected the to-be-added position by:
1. Grepped subscription options, e.g. <literal>two_phase</literal>
2. Found a first place of above detection in each sgml files.
3. Replaced them link, e.g. <xref linkend="sql-createsubscription-with-two-phase"/>.
"XXX = YYY" style was not replaced because there are few links of its style for now.
[1]: https://www.postgresql.org/message-id/flat/CAGPVpCQvAziCLknEnygY0v1-KBtg+Om-9JHJYZOnNPKFJPompw(at)mail(dot)gmail(dot)com
[2]: https://www.postgresql.org/message-id/CAB8KJ=jpuQU9QJe4+RgWENrK5g9jhoysMw2nvTN_esoOU0=a_w@mail.gmail.com
[3]: https://www.postgresql.org/message-id/3bac458c-b121-1b20-8dea-0665986faa40@gmx.de
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-XML-ID-attributes-to-create_subscription.sgml.patch | application/octet-stream | 12.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-03-23 06:23:05 | RE: Allow logical replication to copy tables in binary format |
| Previous Message | Masahiko Sawada | 2023-03-23 06:08:25 | Re: Should vacuum process config file reload more often |