| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Brar Piening' <brar(at)gmx(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: doc: add missing "id" attributes to extension packaging page |
| Date: | 2023-03-29 04:52:56 |
| Message-ID: | TYAPR01MB586655CF4B437AC78D82CDDEF5899@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear my comrade Brar,
> Thanks, I actually was not aware of this.
>
> Also, kudos for capturing the missing id and advocating for consistency
> regarding ids even before this is actively enforced. This nurtures my
> optimism that consistency might actually be achieveable without
> everybody getting angry at me because my patch will enforce it.
>
> Regarding the overlap, I currently try to make it as easy as possible
> for a potential committer and I'm happy to rebase my patch upon request
> or if Kuroda-san's patch gets applied first.
FYI - my patch is pushed [1]. Could you please rebase your patch?
I think it's ok to just remove changes from logical-replication.sgml, ref/alter_subscription.sgml,
and ref/create_subscription.sgml.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo NAGATA | 2023-03-29 04:53:52 | Using Ephemeral Named Relation like a temporary table |
| Previous Message | Kyotaro Horiguchi | 2023-03-29 04:21:55 | Re: Should vacuum process config file reload more often |