| From: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
|---|---|
| To: | 'Justin Pryzby' <pryzby(at)telsasoft(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: [POC] Fast COPY FROM command for the table with foreign partitions |
| Date: | 2021-03-04 02:24:24 |
| Message-ID: | TYAPR01MB2990B8451B4C725242E270F7FE979@TYAPR01MB2990.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
> Find attached some language fixes.
Thanks a lot! (I wish there will be some tool like "pgEnglish" that corrects English in code comments and docs.)
> |/* Do this to ensure we've pumped libpq back to idle state */
>
> I don't know why you mean by "pumped"?
I changed it to "have not gotten extra results" to match the error message.
> The CopySendEndOfRow "case COPY_CALLBACK:" should have a "break;"
Added.
> This touches some of the same parts as my "bulk insert" patch:
> https://commitfest.postgresql.org/32/2553/
My colleague will be reviewing it.
Regards
Takayuki Tsunakawa
| Attachment | Content-Type | Size |
|---|---|---|
| v17-0001-Fast-COPY-FROM-into-the-foreign-or-sharded-table.patch | application/octet-stream | 49.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-03-04 02:24:25 | Re: n_mod_since_analyze isn't reset at table truncation |
| Previous Message | Michael Paquier | 2021-03-04 02:21:06 | Re: archive_command / pg_stat_archiver & documentation |