| From: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
|---|---|
| To: | 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org>, "iwata(dot)aya(at)fujitsu(dot)com" <iwata(dot)aya(at)fujitsu(dot)com>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: libpq debug log |
| Date: | 2021-03-05 06:17:25 |
| Message-ID: | TYAPR01MB2990065BA2D1E35657516C10FE969@TYAPR01MB2990.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> But I think passing the message start address explicitly might be better than
> having it understand the buffering behavior in enough detail to know where to
> find the message. Part of the point here
> (IMO) is to decouple the tracing logic from the core libpq logic, in hopes of not
> having common-mode bugs.
Ouch, you're perfectly right. Then let's make the signature:
void pqLogMessage(PGconn *conn, const char *message, bool toServer);
Thank you!
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-03-05 06:31:33 | Re: n_mod_since_analyze isn't reset at table truncation |
| Previous Message | Julien Rouhaud | 2021-03-05 06:05:22 | Re: Shared memory size computation oversight? |