| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Daniil Davydov <3danissimo(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Wrong comment for ReplicationSlotCreate |
| Date: | 2026-01-05 06:25:41 |
| Message-ID: | TY7PR01MB14554EBB092B6823829CF0A0DF586A@TY7PR01MB14554.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
>
> I think it is better if we add some comments atop
> ReplicationSlotAlter() as you are suggesting. What do you think of the
> attached?
Thanks for attaching the patch. There is a small typo:
> + * clinet-side. Enabling it at any random point during decoding has the
"clinet" should be client. Others are OK for me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-01-05 06:33:17 | Re: Resetting recovery target parameters in pg_createsubscriber |
| Previous Message | Dilip Kumar | 2026-01-05 06:12:46 | Re: Proposal: Conflict log history table for Logical Replication |