Re: Proposal: recent access based routing for primary-replica setups

From: Koshino Taiki <koshino(at)sraoss(dot)co(dot)jp>
To: Nadav Shatz <nadav(at)tailorbrands(dot)com>
Cc: "pgpool-hackers(at)lists(dot)postgresql(dot)org" <pgpool-hackers(at)lists(dot)postgresql(dot)org>, Tatsuo Ishii <ishii(at)postgresql(dot)org>
Subject: Re: Proposal: recent access based routing for primary-replica setups
Date: 2026-11-11 09:41:44
Message-ID: TY7P286MB9749441EA6822ABC86121DD30494712@TY7P286MB974944.JPNP286.PROD.OUTLOOK.COM
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgpool-hackers

Hi Nadav,

The replication_delay_source_cmd documentation says:

Delay values can be integers or floating-point numbers.

When the command returns a value like "unknown",
check_replication_time_lag_with_cmd() in
src/streaming_replication/pool_worker_child.c checks whether strtod()
left any characters unparsed. If so, it logs a warning and records
the delay as zero.

I thought it would be helpful to make this behavior explicit in the
documentation. The attached patch adds the following sentence:

If a delay value cannot be parsed in full as a number, Pgpool-II
logs a warning and treats the value as zero milliseconds.

Does this wording look right to you?

Best Regards,

Taiki Koshino<koshino(at)sraoss(dot)co(dot)jp>
SRA OSS K.K.
TEL: 03-5979-2701 FAX: 03-5979-2702
URL: https://www.sraoss.co.jp/

________________________________
差出人: Nadav Shatz <nadav(at)tailorbrands(dot)com>
送信日時: 2026年1月8日 13:59
宛先: Tatsuo Ishii <ishii(at)postgresql(dot)org>
CC: pgpool-hackers(at)lists(dot)postgresql(dot)org <pgpool-hackers(at)lists(dot)postgresql(dot)org>
件名: Re: Proposal: recent access based routing for primary-replica setups

Much much better and cleaner! Thanks!

Nadav Shatz
Tailor Brands | CTO

On Thu, Jan 8, 2026 at 4:19 AM Tatsuo Ishii <ishii(at)postgresql(dot)org<mailto:ishii(at)postgresql(dot)org>> wrote:
Hi Nadav,

I have just noticed that check_replication_time_lag_with_cmd() can be
simplified by using StringInfo functions. Patch attached. What do you
think?

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Attachment Content-Type Size
v1-0001-Doc-Clarify-handling-of-non-numeric-replication-d.patch application/octet-stream 1.3 KB

In response to

Responses

Browse pgpool-hackers by date

  From Date Subject
Next Message Nadav Shatz 2026-11-11 09:45:37 Re: Proposal: recent access based routing for primary-replica setups
Previous Message Koshino Taiki 2026-11-11 08:57:22 Re: Proposal: Recent mutated table tracking in memory