| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Distinguish publication exclusions in object addresses |
| Date: | 2026-09-16 05:54:46 |
| Message-ID: | TY4PR01MB17718ECD62213EF5425DFB5C894B92@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, September 16, 2026 12:51 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> Some review comments for v3:
>
>
> ======
> src/backend/catalog/aclchk.c
>
> + case OBJECT_PUBLICATION_EXCLUDED_REL:
> case OBJECT_PUBLICATION_NAMESPACE:
> case OBJECT_PUBLICATION_REL:
>
> The new enum name OBJECT_PUBLICATION_EXCLUDED_REL is closely
> related to OBJECT_PUBLICATION_REL.
>
> IMO, a better name would be OBJECT_PUBLICATION_REL_EXCLUDED, so
> these related things are kept adjacent alphabetically and in the code.
I think all object type names end with a noun, whereas the proposed name
doesn't, so I don't find it better. Also, the order of an enum value doesn't
provide enough value to justify the change, in my view.
Best Regards,
Zhijie Hou
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-09-16 05:54:58 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |
| Previous Message | Amit Kapila | 2026-09-16 05:50:47 | Re: Distinguish publication exclusions in object addresses |