| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "onderkalaci(at)gmail(dot)com" <onderkalaci(at)gmail(dot)com> |
| Subject: | RE: Logical replication can lose an update after concurrent index invalidation |
| Date: | 2026-08-31 02:59:17 |
| Message-ID: | TY4PR01MB17718D1B079F36D532CAADB6D94A92@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, August 28, 2026 8:15 PM Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
>
> In v2 I put a new flag into padding and used the same pattern for the function
> as in 9e47718250d.
Thanks for sharing the patch.
The patch looks mostly good to me.
One nit for back-branch patches: I see you've created a new API that accepts
isIdxSafeToSkipDuplicates. In that case, we shall mention in the comments
atop the old function that it should not be used in new code anymore, otherwise
extensions might also encounter the same issue. We've added something like
below comments for other commits:
* ABI-compatible wrapper to emulate old version of the
* xxx function. Do not call this version in new code.
BTW, just to share, I'm reviewing this with an eye for whether other similar
code paths have the same problem. The other two GetRelationIdentityOrPK callers
in logicalrep also look worth adjusting on top of the current patch's new flag
(maybe in followup patches):
The one in check_relation_updatable() may cause the apply worker to report the
wrong error message.
The one in conflict.c could output wrong identity information.
Best Regards,
Zhijie Hou
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Sami Imseih | 2026-08-31 02:56:29 | Re: WAIT FOR command should do some query jumbling |