| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Remove stale XXX comment in logical launcher |
| Date: | 2026-09-07 05:17:09 |
| Message-ID: | TY4PR01MB17718CEAE3E330A24936393B194B22@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Friday, September 4, 2026 2:12 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Sep-03, Amit Kapila wrote:
> >
> > Adding such a comment at the time of creation sounds reasonable to me.
> > I would still like to check with Alvaro who added this comment in
> > commit 2af1dc89282bea681201cf66e2bb32537294e623 whether such a
> > comment would make it easier to follow this part of code?
>
> I agree that having a comment stating that the slot we hold is necessarily
> physical would be good. It wouldn't hurt to see exactly what is being
> proposed though.
Thanks for confirming.
Here is the updated patch with the suggested comments.
Best Regards,
Zhijie Hou
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-stale-XXX-comment-in-logical-launcher.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | JoongHyuk Shin | 2026-09-07 05:21:21 | [PATCH] Add recovery boundary WAL record for database and tablespace commands |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-09-07 05:05:10 | RE: pg_createsubscriber does not check output_plugin_libraries |