| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | RE: Adding REPACK [concurrently] |
| Date: | 2026-05-27 08:08:41 |
| Message-ID: | TY4PR01MB177189B910069E99897E4323D94082@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, May 26, 2026 11:32 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> On 2026-May-25, Zhijie Hou (Fujitsu) wrote:
>
> > After listening to the REPACK talk at pgconf.dev this year, I
> > understand that WAL accumulation during REPACK CONCURRENTLY is not
> > intended behavior. I think we can consider fixing this in the current
> > release. Attached is the rebased patch, with comments adjusted based on
> Chao Li's comments.
>
> You're right, this is a thinko. I'll look at your patch hoping to get it pushed
> shortly. I wonder if we should add a TAP test to verify that WAL files are
> actually removed? Sounds a bit excessive TBH, but maybe it isn't really.
I tried a bit, and the test complexity and speed (< 1s) appear to be within
acceptable limits. I'm attaching 0002 as a reference test.
0001 remains unchanged.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Allow-old-WAL-recycling-during-REPACK-CONCURRENTL.patch | application/octet-stream | 3.0 KB |
| v3-0002-Add-a-test-for-repack-concurrently.patch | application/octet-stream | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-05-27 08:11:55 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |
| Previous Message | Chao Li | 2026-05-27 07:55:38 | Re: Fix bug of UPDATE/DELETE FOR PORTION OF with inheritance tables |