RE: Distinguish publication exclusions in object addresses

Hi,

On Monday, September 14, 2026 12:29 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> The attached patches have the changes for the same.
> v1-0001-Distinguish-publication-exclusions-in-object-addr.patch is the same
> Fujii Masao-san's patch from [2]. The comment fixes are present in
> v1-0002-Review-comment-fixes.patch which is a top-up patch on top of Fujii
> Masao-san's patch.

Thanks for sharing the patches.

I have one question for 0001:

The changes in pg_get_object_address() look a bit hacky to me. Instead of
hard-coding a string comparison and adding a special branch to handle the
excluded publication relation, wouldn't it be more standard to introduce a new
object type, such as OBJECT_PUBLICATION_EXCLUDED_REL? I think that would make
the code more elegant, and we could pass the object type directly to
get_object_address_publication_rel() instead of using a Boolean flag. That said, are
there any reasons we cannot add a new object type?

Best Regards,
Zhijie Hou