| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | RE: Adding REPACK [concurrently] |
| Date: | 2026-06-01 02:25:59 |
| Message-ID: | TY4PR01MB1771838FAEA8614A388EF138E94152@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Saturday, May 30, 2026 6:25 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2026-May-27, Zhijie Hou (Fujitsu) wrote:
>
> > I tried a bit, and the test complexity and speed (< 1s) appear to be
> > within acceptable limits. I'm attaching 0002 as a reference test.
> >
> > 0001 remains unchanged.
>
> Pushed 0001, in two parts. I rewrote the comment in
> decode_concurrent_changes() though, hope it ended up okay.
Thank you for pushing the patches ! The comments look good to me.
In the original 0002 test patch, I realized that I missed to drop existing slots
from previous tests (I did locally but missed to merge into the patch), which
also prevented WAL removal, sorry for that. Attached is the fixed test patch.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Add-TAP-test-for-WAL-recycling-during-REPACK-CONC.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-06-01 02:29:21 | Re: Row pattern recognition |
| Previous Message | Tatsuo Ishii | 2026-06-01 02:11:19 | Re: Row pattern recognition |