RE: Fix race in ReplicationSlotRelease for ephemeral slots

On Saturday, May 30, 2026 1:44 AM Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com> wrote:

> > On Wed, May 27, 2026 at 5:20 PM Zhijie Hou (Fujitsu) <mailto:houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > I haven't attached a test for this fix, as the change is straightforward and the
> > Likelihood of encountering this bug is low, so it may not be worth adding test
> > cycles for it. However, if others feel differently, I'm OK to add one.
>
> +1 for a test. The fix is just an else, so a future refactor could change it and silently
> reintroduce the corruption, since it scribbles on an unrelated reused slot, nothing
> would catch it. Injection points make it deterministic; I've attached a diff patch that adds
> a test that fails without the fix and passes with it.

Thanks for the test.

I'm not sure if adding an injection point for this rare case is worthwhile. Even
if we were to add one, future refactoring of that function could shift the
position of the injection point, so its long-term usefulness is uncertain. I
don't have a strong opinion on this, so I'll leave it to Fujii-San to decide.

Best Regards,
Hou zj