RE: Conflict detection for update_deleted in logical replication

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: RE: Conflict detection for update_deleted in logical replication
Date: 2025-08-29 06:19:44
Message-ID: TY4PR01MB16907EFB6A402FB1D3CEF7E3B943AA@TY4PR01MB16907.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thursday, August 28, 2025 7:09 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Aug 28, 2025 at 8:02 AM Zhijie Hou (Fujitsu)
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > I noticed that Cfbot failed to compile the document due to a typo
> > after renaming the subscription option. Here are the updated V67
> > patches to fix that, only the doc in 0001 is modified.
> >
>
> I have made a number of cosmetic and comment changes in the attached atop
> 0001 patch. Kindly include in next version, if you think they are good to include.

Thanks ! The changes look good to me, I have merged them into V68 patch set.

Here is the new version patch set which also addressed Shveta's comments[1].

[1] https://www.postgresql.org/message-id/CAJpy0uD%3DMLy77JZ78_J4H3XCV1mCA%3DiUPHuFC5Vt4EKyj6zfjg%40mail.gmail.com

Best Regards,
Hou zj

Attachment Content-Type Size
v68-0003-Add-a-dead_tuple_retention_active-column-in-pg_s.patch application/octet-stream 8.1 KB
v68-0001-Introduce-a-max_retention_duration-option-to-sub.patch application/octet-stream 101.9 KB
v68-0002-Resume-retaining-the-information-for-conflict-de.patch application/octet-stream 20.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2025-08-29 06:22:53 RE: Conflict detection for update_deleted in logical replication
Previous Message Ajin Cherian 2025-08-29 06:12:39 Re: Improve pg_sync_replication_slots() to wait for primary to advance