RE: doc: update the default of data checksums in the doc of pg_rewind

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: doc: update the default of data checksums in the doc of pg_rewind
Date: 2025-12-25 03:15:02
Message-ID: TY4PR01MB16907C9A3A68653E8DF44EE5A94B3A@TY4PR01MB16907.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thursday, December 25, 2025 8:04 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Dec 24, 2025 at 4:28 PM Zhijie Hou (Fujitsu)
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > Hi,
> >
> > I noticed that the pg_rewind documentation still states that data
> > checksums is disabled by default, but it has been changed to on since PG18.
> >
> > Here's a small patch to update this.
>
> Thanks for the patch!
>
> - the cluster was initialized with
> <application>initdb</application>. Neither of these
> - are currently on by default. <xref linkend="guc-full-page-writes"/>
> - must also be set to <literal>on</literal>, but is enabled by default.
> + the cluster was initialized with <application>initdb</application>
> (the latter
> + being the default). <xref linkend="guc-full-page-writes"/> must also be set
> + to <literal>on</literal>, but is enabled by default.
>
> Isn't "(the default)" enough here instead of "(the latter being the default)"?

Agreed. Here is the updated patch.

Best Regards,
Hou zj

Attachment Content-Type Size
v2-0001-Fix-outdated-doc-in-pg_rewind.patch application/octet-stream 1.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2025-12-25 03:16:34 RE: doc: update the default of data checksums in the doc of pg_rewind
Previous Message Zhijie Hou (Fujitsu) 2025-12-25 03:14:19 RE: doc: update the default of data checksums in the doc of pg_rewind