| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Logical Replication of sequences |
| Date: | 2025-10-14 10:03:16 |
| Message-ID: | TY4PR01MB16907A2DDF2D7FC41909BCF9E94EBA@TY4PR01MB16907.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, October 13, 2025 3:28 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> Please find few initial comments for 002:
Thanks for the comments.
>
>
> 5)
> CheckSubscriptionRelkind
> + if (pubrelkind == '\0')
> + return;
>
> Do you think, we shall write a comment in the function header that the caller
> who wants to verify only the supported type should pass pubrelkind as '\0'?
This check is removed due to some other changes.
All other comments have been addressed in the latest version.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-10-14 10:03:35 | RE: Logical Replication of sequences |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-10-14 10:02:52 | RE: Logical Replication of sequences |