RE: Conflict detection for update_deleted in logical replication

On Monday, September 15, 2025 12:52 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Sep 12, 2025 at 3:39 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> >
> > Here is the V74 patch which addressed all comments.
> >
>
> + ereport(LOG,
> + errmsg("logical replication worker for subscription \"%s\" will
> resume retaining the information for detecting conflicts",
> + MySubscription->name),
> + MySubscription->maxretention
> + ? errdetail("Retention of information used for conflict detection is
> now within the max_retention_duration of %u ms.",
> + MySubscription->maxretention)
> + : errdetail("Retention of information used for conflict detection is
> now indefinite."));
>
> The detail message doesn't seems to convey the correct meaning as the
> duration is compared with something vague. How about changing errdetail
> messages as follows:
> "Retention is re-enabled as the apply process is advancing its xmin within the
> configured max_retention_duration of %u ms."
> "Retention is re-enabled as max_retention_duration is set to unlimited."
>
> If you agree with the above then we can consider changing the existing errdetail
> related to stop_retention functionality as follows:
> "Retention is stopped as the apply process is not advancing its xmin within the
> configured max_retention_duration of %u ms."
>
> Apart from these, I have made some cosmetic changes in the attached.

Thanks, the changes look good to me. I have merged them in V75 patch.

Best Regards,
Hou zj