| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'vignesh C' <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | RE: Logical Replication of sequences |
| Date: | 2025-10-15 11:21:03 |
| Message-ID: | TY4PR01MB169077BDFB4F9D7E82E280D7C94E8A@TY4PR01MB16907.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, October 14, 2025 8:09 PM Kuroda, Hayato/黒田 隼人 <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Hou,
>
> Thanks for updating the patch. Here are comments for recent 0002.
> Others are still being reviewed
Thanks for the comments.
> 04. check_publications_origin
> ```
> +
> + query = "SELECT DISTINCT P.pubname AS pubname\n"
> + "FROM pg_publication P,\n"
> + " LATERAL %s GPR\n"
> ...
> pgindent does not like the notation. How aboout chaning the line after the "="?
> I.e.,
>
> ```
> query =
> "SELECT DISTINCT P.pubname AS pubname\n"
> "FROM pg_publication P,\n"
> " LATERAL %s GPR\n"
> ...
> ```
I chose to accept what pgindent suggests instead of doing more adjustments.
All other comments have been addressed in the latest version.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2025-10-15 11:21:17 | RE: Logical Replication of sequences |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-10-15 11:20:52 | RE: Logical Replication of sequences |