RE: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?
Date: 2026-03-31 10:26:33
Message-ID: TY4PR01MB16907318494FF276465E97DF79453A@TY4PR01MB16907.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday, March 31, 2026 2:02 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
>
> Please find the updated patch (v6) attached.

Thanks for updating the patch. One minor comment:

I think we could avoid interrupting and reporting an ERROR when
IsSyncingReplicationSlots() returns false to avoid reporting ERROR unnecessarily
when the slotsync has already finished.

Best Regards,
Hou zj

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-03-31 10:42:00 Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?
Previous Message Christoph Berg 2026-03-31 10:18:49 Re: pgsql: test_aio: Add basic tests for StartReadBuffers()