RE: Logical Replication of sequences

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: RE: Logical Replication of sequences
Date: 2025-10-15 11:20:49
Message-ID: TY4PR01MB169071930F366BCEA180A94D694E8A@TY4PR01MB16907.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wednesday, October 15, 2025 3:03 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:

>
> On Tue, Oct 14, 2025 at 5:08 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > On Tue, Oct 14, 2025 at 3:36 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> >
> > 0001 and 0002 looks good,
> >
>
> Thanks, I pushed 0001. I feel it is better to next commit refactoring patch
> v20251014-0003-Reorganize-tablesync-Code-and-Introduce-sy as that would
> be less controversial. What do you think?

I agree and has reordered the latest patch set.

>
> > except this duplicate version checking code below in fetch_relation_list
> [1][2], I mean check_relkind and sequence fetching both are related changes
> and start from version 19, so we can do a single check. Instead of the
> 'check_relkind' variable name we can change it to 'support_relkind_seq' or
> something like that and then we can use this in both checks.
> >
>
> Sounds reasonable to me.

Changed as suggested.

Here is the new version patch set which includes the following changes:

0001:
* Addressed comments from Shveta[1] and Chao li[2].

0002
* Addressed Shveta[3], Kuroda-San[4] and Dilip's comments[5].

TODO:
* The comments on 0003 patch by Amit[6].
* The comment from Amit[7] to avoid creating slot/origin for sequence only subscription.

[1] https://www.postgresql.org/message-id/CAJpy0uCSKChetEw1buBrZu3vAV8OYv3X9MygNxKHw5WWzMd1Gg%40mail.gmail.com
[2] https://www.postgresql.org/message-id/158C2EDB-D505-46A6-996D-296EC1B3ACE2%40gmail.com
[3] https://www.postgresql.org/message-id/CAJpy0uCPuTLEkuC7kbXwvyUuxrtKOhDb9A3ti6EhOKgzMNkbcQ%40mail.gmail.com
[4] https://www.postgresql.org/message-id/OSCPR01MB14966B8BB27B784674506C9A8F5EBA%40OSCPR01MB14966.jpnprd01.prod.outlook.com
[5] https://www.postgresql.org/message-id/CAA4eK1%2BHb4H9z8C5kiuc42%3Dw%3DPi9dQAioJW%3D2OSr9eAnpoxF6w%40mail.gmail.com
[6] https://www.postgresql.org/message-id/CAA4eK1J8UYFPgcM5b0aHvbRT_3pVNUpnpvypQU5vqk4Uu%3DmXVg%40mail.gmail.com
[7] https://www.postgresql.org/message-id/CAA4eK1J%3Dgc8WXVc2Hy0Xcq4KtWU-z-dxBiZHbT62jz3QPBZ5CQ%40mail.gmail.com

Best Regards,
Hou zj

Attachment Content-Type Size
v20251015-0002-Introduce-REFRESH-SEQUENCES-for-subscripti.patch application/octet-stream 45.6 KB
v20251015-0001-Reorganize-tablesync-Code-and-Introduce-sy.patch application/octet-stream 28.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2025-10-15 11:20:52 RE: Logical Replication of sequences
Previous Message Arseniy Mukhin 2025-10-15 11:19:40 Re: Optimize LISTEN/NOTIFY