| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-11-30 04:12:50 |
| Message-ID: | TY3PR01MB988913BBE71B519F29AD041FF582A@TY3PR01MB9889.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
> Sorry, my analysis was not complete. On looking closely, I think the
> reason is that we are allowed to upgrade the slot iff there is no
> pending WAL to be processed.
Yes, the guard will strongly protect from data loss, but I do not take care in the test.
> The test first disables the subscription
> to avoid unnecessary LOGs on the subscriber and then stops the
> publisher node.
Right. Unnecessary ERROR would be appeared if we do not disable.
> It is quite possible that just before the shutdown of
> the server, autovacuum generates some WAL record that needs to be
> processed,
Yeah, pg_upgrade does not ensure that autovacuum is not running *before* the
upgrade.
> so you propose just disabling the autovacuum for this test.
Absolutely correct.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-11-30 04:14:14 | Re: [PATCH] Native spinlock support on RISC-V |
| Previous Message | Shubham Khanna | 2023-11-30 04:11:51 | Re: Postgres Partitions Limitations (5.11.2.3) |