RE: WIP: WAL prefetch (another approach)

From: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Tomas Vondra" <tomas(dot)vondra(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: WIP: WAL prefetch (another approach)
Date: 2021-04-13 02:33:12
Message-ID: TU4PR8401MB1152945E4FD45E99C3F52B94EE4F9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for developing a great feature. I tested this feature and checked the documentation.
Currently, the documentation for the pg_stat_prefetch_recovery view is included in the description for the pg_stat_subscription view.

https://www.postgresql.org/docs/devel/monitoring-stats.html#MONITORING-PG-STAT-SUBSCRIPTION

It is also not displayed in the list of "28.2. The Statistics Collector".
https://www.postgresql.org/docs/devel/monitoring.html

The attached patch modifies the pg_stat_prefetch_recovery view to appear as a separate view.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Thomas Munro [mailto:thomas(dot)munro(at)gmail(dot)com]
Sent: Saturday, April 10, 2021 5:46 AM
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>; Stephen Frost <sfrost(at)snowman(dot)net>; Andres Freund <andres(at)anarazel(dot)de>; Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>; Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>; Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>; Dmitry Dolgov <9erthalion6(at)gmail(dot)com>; David Steele <david(at)pgmasters(dot)net>; pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: WAL prefetch (another approach)

On Sat, Apr 10, 2021 at 8:37 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> Did you see this?
> INVALID URI REMOVED
> 278MB0483490FEAC879DCA5ED583DD2739*40GV0P278MB0483.CHEP278.PROD.OUTLOO
> K.COM__;JQ!!NpxR!wcPrhiB2CaHRtywGoh9Ap0M-kH1m07hGI37-ycYRGCPgCqGs30lRS
> KicsXacduEXHxI$
>
> I meant to mail you so you could include it in the same commit, but
> forgot until now.

Done, thanks.

Attachment Content-Type Size
pg_stat_prefetch_recovery_doc_v1.diff application/octet-stream 3.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2021-04-13 02:34:18 Re: [PATCH] Identify LWLocks in tracepoints
Previous Message Masahiko Sawada 2021-04-13 02:22:13 Re: vacuum freeze - possible improvements