RE: Multivariate MCV list vs. statistics target

From: "Shinoda, Noriyoshi (PN Japan A&PS Delivery)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Multivariate MCV list vs. statistics target
Date: 2020-03-18 04:28:34
Message-ID: TU4PR8401MB115254BB9F5C19D3B8D8F7F7EEF70@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

I found a missing column description in the pg_statistic_ext catalog document for this new feature.
The attached patch adds a description of the 'stxstattarget' column to pg_statistic_ext catalog's document.
If there is a better explanation, please correct it.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Tomas Vondra [mailto:tomas(dot)vondra(at)2ndquadrant(dot)com]
Sent: Wednesday, September 11, 2019 7:28 AM
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>; Jamison, Kirk <k(dot)jamison(at)jp(dot)fujitsu(dot)com>; Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>; PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Multivariate MCV list vs. statistics target

On Tue, Sep 03, 2019 at 02:38:56PM -0400, Alvaro Herrera wrote:
>On 2019-Aug-01, Tomas Vondra wrote:
>
>> I'll move it to the next CF. Aside from the issues pointed by
>> Kyotaro-san in his review, I still haven't made my mind about whether
>> to base the use statistics targets set for the attributes. That's
>> what we're doing now, but I'm not sure it's a good idea after adding separate statistics target.
>> I wonder what Dean's opinion on this is, as he added the current logic.
>
>Latest patch no longer applies. Please update. And since you already
>seem to have handled all review comments since it was Ready for
>Committer, and you now know Dean's opinion on the remaining question,
>please get it pushed.
>

OK, I've pushed this the patch, after some minor polishing.

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
pg_statistic_ext_doc_v1.diff application/octet-stream 966 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-03-18 04:33:05 Re: Adding missing object access hook invocations
Previous Message Michael Paquier 2020-03-18 04:20:47 Re: Online checksums verification in the backend