| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Roman Khapov <rkhapov(at)yandex-team(dot)ru>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-01-14 15:11:19 |
| Message-ID: | SYAPR01MB3038D03B8FE3421857752159B68FA@SYAPR01MB3038.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 14 Jan 2026 at 20:03, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> On Wed, 14 Jan 2026 at 19:51, Japin Li <japinli(at)hotmail(dot)com> wrote:
>>
>> On Wed, 14 Jan 2026 at 17:44, Roman Khapov <rkhapov(at)yandex-team(dot)ru> wrote:
>> >> I agree ā the NULL handling seems wrong.
>> >> Here's a quick patch to fix it. What do you think?
>> >
>> > LGTM, but maybe the test should be expanded with NULL for the two-column
>> > indexes? I mean to add NULLs at zero column too.
>> >
>>
>> Sorry, Iām not sure I understand.
>>
>> Are you suggesting we add one (or both) of these test cases?
>>
>> INSERT INTO test1 VALUES (2, NULL, NULL);
>> INSERT INTO test1 VALUES (2, ARRAY[NULL, 222], ARRAY['d', NULL]);
>>
>
> Yes, like this, to have gin_entrypage_items to output y=NULL and
> z=NULL for y_z index
>
Thanks for the suggestion!
I think one of those test cases is sufficient ā I'll include it in the next
version.
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-01-14 15:20:02 | Re: Buffer locking is special (hints, checksums, AIO writes) |
| Previous Message | Kirill Reshke | 2026-01-14 15:07:41 | Re: Add IS_INDEX macro to brin and gist index |