| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | 邱宇航 <iamqyh(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Transaction timeout |
| Date: | 2023-12-08 10:29:17 |
| Message-ID: | SY8PR01MB9288335A3B81E8D6E121980FB68AA@SY8PR01MB9288.ausprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 08 Dec 2023 at 18:08, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>> On 8 Dec 2023, at 12:59, Japin Li <japinli(at)hotmail(dot)com> wrote:
>>
>>
>> On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>>>> On 7 Dec 2023, at 06:25, Japin Li <japinli(at)hotmail(dot)com> wrote:
>>>>
>>>> If idle_in_transaction_timeout is bigger than transaction_timeout,
>>>> the idle-in-transaction timeout don't needed, right?
>>> Yes, I think so.
>>>
>>
>> Should we disable the idle_in_transaction_timeout in this case? Of cursor, I'm
>> not strongly insist on this.
> Good idea!
>
>> I think you forget disable transaction_timeout in AutoVacWorkerMain().
>> If not, can you elaborate on why you don't disable it?
>
> Seems like code in autovacuum.c was copied, but patch was not updated. I’ve fixed this oversight.
>
Thanks for updating the patch. LGTM.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2023-12-08 10:34:29 | Re: remaining sql/json patches |
| Previous Message | Alexander Korotkov | 2023-12-08 10:27:16 | Re: [HACKERS] make async slave to wait for lsn to be replayed |