| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Inconsistent LSN format in pg_waldump output |
| Date: | 2025-07-04 02:32:20 |
| Message-ID: | SY8P300MB0442D7B3138C04044A3D2332B642A@SY8P300MB0442.AUSP300.PROD.OUTLOOK.COM |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 03 Jul 2025 at 18:07, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> On 2025-Jul-03, Japin Li wrote:
>
>> Providing two LSN formats — %X%08X for translatable messages and
>> LSN_FORMAT for non-translatable ones — seems to offer no clear advantage.
>>
>> I'd prefer to use %X/%08X directly and add the description to the
>> LSN_FORMAT_ARGS macro.
>
> WFM.
>
Many thanks! V4 of the patch is now attached.
I've opted to directly use %X/%08X for LSN formatting in this patch, with an
accompanying comment near LSN_FORMAT_ARGS.
--
Regards,
Japin Li
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Standardize-LSN-formatting-by-zero-padding.patch | text/x-diff | 171.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2025-07-04 02:48:25 | Re: Making pg_rewind faster |
| Previous Message | Rahila Syed | 2025-07-04 02:12:58 | Re: Improve error message for duplicate labels in enum types |