| From: | Li Japin <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Duplicate function call on timestamp2tm |
| Date: | 2019-12-12 16:04:53 |
| Message-ID: | SG2PR06MB3776DC04EA41E8FDC509B36CB6550@SG2PR06MB3776.apcprd06.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for your confirm. Is there anything I can do?
On Dec 12, 2019, at 11:13 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us<mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
Ah, after looking in the git history, not quite that ancient:
this duplication dates to commit 258ee1b63, which moved these
switch cases from the "if (type == RESERV)" switches in the
same functions. In the previous coding these function calls
were actually necessary, but here they're redundant. I guess
that's just additional ammunition for Greg's point that the
keywords were misclassified ;-).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Khandekar | 2019-12-12 16:20:12 | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |
| Previous Message | Mark Dilger | 2019-12-12 16:02:25 | Re: Make autovacuum sort tables in descending order of xid_age |