Re: [PG19] pg_upgrade --check passes, then the upgrade fails

Hi all,

One more case for the general check in master: privileges granted on a
GUC that the new version removed (pg_parameter_acl). pg_upgrade --check
passes, and the globals restore then fails.

Repro, REL_18_STABLE (03ba8e5) -> master (328a9a1):

-- old cluster (18)
CREATE ROLE r1;
GRANT SET ON PARAMETER escape_string_warning TO r1;

$ pg_upgrade ... --check
*Clusters are compatible*
$ pg_upgrade ...
Restoring global objects in the new cluster *failure*

GRANT SET ON PARAMETER "escape_string_warning" TO "r1";
ERROR: unrecognized configuration parameter "escape_string_warning"

The same grant on work_mem upgrades fine, and revoking the grant before
the upgrade avoids the failure.

agree it does not need to block 19. But when the generic check for
stored settings is done, it seems worth reading pg_parameter_acl as well
as pg_db_role_setting.

Regards,
Adesh