Re: Another nasty pg_dump problem

Tom Lane writes:

> I've repaired this in CVS tip. While testing it, though, I notice that
> CVS-tip pg_dump puts out useless commands
>
> REVOKE ALL ON SCHEMA public FROM PUBLIC;
> GRANT ALL ON SCHEMA public TO PUBLIC;
>
> which are not generated when dumping from 7.3. The reason evidently is
> that this check in pg_dump.c no longer works:

This could be fixed, but note that elsewhere we use

/*
* Always start with REVOKE ALL FROM PUBLIC, so that we don't have to
* wire-in knowledge about the default public privileges for different
* kinds of objects.
*/
appendPQExpBuffer(firstsql, "REVOKE ALL ON %s %s FROM PUBLIC;\n",
type, name);

So maybe this isn't such a bad state after all.

--
Peter Eisentraut peter_e(at)gmx(dot)net