Re: Bugs in comment moderation scripts

On Thu, 23 Dec 2004, Robert Treat wrote:

> I will say thought that the admin script are a little buggy... when I
> rejected this comment, I thought I would be taken to a web page to allow
> me to explain why the comment was going to be rejected, but after
> authenticating i was given some redirect which require authenticating
> again which brought me to a "it's been rejected" screen... ie. i never
> got a chance to explain why I rejected it (was going to tell the person
> to point to the mailing list).

Looking at what's in CVS, it looks like there's a step missing. When you
reject a comment, it puts together an E-Mail to the person who submitted it
saying "Your comment was rejected from PostgreSQL manual" with the body
"Insert a semi-friendly explanation here \n The original comment follows".

Unfortunately, it sends that right away without allowing you to edit it, as
far as I can tell (my language of choice is Perl, not PHP, so I might be
missing something, but it looks clear enough).

I think we need another QuickForm for editing the comment, which may be best
put in a different file than comments.php.

> On another one, I clicked the edit screen and instead of getting a box
> to edit the content, I just got a search box to look for comments.

That *should* only happen if you went to the comment-edit.php page without
an "?id=___" somehow... It doesn't look like this happens in any of the
links (either in the E-Mail or on the form), though.

Steve

--
Steve Simms <steve(at)deefs(dot)net>
http://www.deefs.net