Re: TODO item -- Improve psql's handling of multi-line

From: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Andreas Seltenreich <uwi7(at)rz(dot)uni-karlsruhe(dot)de>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: TODO item -- Improve psql's handling of multi-line
Date: 2005-12-04 19:17:33
Message-ID: Pine.LNX.4.44.0512042205230.22088-200000@lnfm1.sai.msu.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hello,

Sorry for not quick problem fixing, I was quite busy last time...

I submit the new version of my patch (against the CVS tip), correcting the
problem with \edit (pointed by Andreas). So now everything works fine.

With Best Regards,

Sergey

On Thu, 1 Dec 2005, Bruce Momjian wrote:

>
> Where are we on this patch? Was it submitted? Applied? Just an idea?
>
> ---------------------------------------------------------------------------
>
> Andreas Seltenreich wrote:
> > Sergey E. Koposov writes:
> >
> > > I'm proposing the small patch for the TODO item -- Improve psql's handling
> > > of multi-line queries. With this patch the multi-line queries are saved
> > > by readline as whole and not line by line.
> >
> > I like it already!
> >
> > > This is my first patch for Postgres but it seems to work and to not break
> > > anything.
> > >
> > > I'm waiting for review, comments, objections, etc...
> >
> > Did you consider its interaction with \e? Editing the query_buffer
> > with \e will leave that query prefixed with \e in the history. That
> > wasn't the case before your patch.
> >
> > Also, using \e several times on a query without sending it (i.e.
> > without a semicolon) will yield a history entry of a concatenation of
> > old query buffers.
> >
> > Thanks,
> > Andreas
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 4: Have you searched our list archives?
> >
> > http://archives.postgresql.org
> >
>
>

*****************************************************
Sergey E. Koposov
Max-Planck Institut for Astronomy
Web: http://lnfm1.sai.msu.ru/~math
E-mail: math(at)sai(dot)msu(dot)ru

Attachment Content-Type Size
psql.patch text/plain 3.0 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Guillaume LELARGE 2005-12-04 19:18:40 French po files
Previous Message Tom Lane 2005-12-04 18:57:44 Re: [PATCHES] snprintf() argument reordering not working