Re: NLS changes

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: NLS changes
Date: 2003-09-15 18:42:24
Message-ID: Pine.LNX.4.44.0309141835460.3283-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Alvaro Herrera writes:

> - adds .y files to gettext-files in backend/nls.mk. gram.y contains
> several translatable messages that are not catched by update-po unless
> the gram.c file is generated. I don't know if this is desirable but I
> think it's better to have to gram.y file processed.
> Maybe this part of the patch could be left out (it's the first,
> trivial chunk).

It's better to make the distprep target a prerequisite of the "find" rule,
so that it really finds all the files in their final form. There are some
circular dependencies that I'll need to sort out. Consider it taken care
of, though.

> - makes more translator-friendly the messages in gram.y, because a lot
> of them are only a keyword away of being equal. This avoids having
> the translator process the same thing several times.

Looks OK.

> - adds a couple of comments for the translator (I had to peek at the
> source code to see what the %s was about, so I guess this is needed).

OK.

> Also, I've noted that psql's \h messages are not translatable. Is there
> a way to make them so?

Yes, I was just about to do that.

--
Peter Eisentraut peter_e(at)gmx(dot)net

In response to

  • NLS changes at 2003-09-14 06:14:22 from Alvaro Herrera

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2003-09-15 20:42:55 Re: libpq-fr.po updated
Previous Message sumit 2003-09-15 17:49:00 CUBE operator