| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] MinGW patch |
| Date: | 2003-09-07 16:08:42 |
| Message-ID: | Pine.LNX.4.44.0309071806490.1172-100000@peter.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-cygwin pgsql-hackers-win32 pgsql-patches |
Bruce Momjian writes:
> The problem is that mbvalidate() has this code:
>
> if (GetVariableBool(pset.vars, "WIN32_CONSOLE"))
> CharToOem(pwcs, pwcs);
>
> That's why I needed the #ifdef so it only tests from psql. This code
> was just broken without that test, and because no one else has done
> Win32 compiles since it was added, no one saw it.
Interesting, considering that WIN32_CONSOLE isn't being set anywhere.
Anyway, that code needs to be removed/fixed, for the mentioned reasons.
--
Peter Eisentraut peter_e(at)gmx(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-09-07 16:21:41 | WIN32_CONSOLE usage |
| Previous Message | Bruce Momjian | 2003-09-07 15:40:33 | Re: [PATCHES] MinGW patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-09-07 16:21:41 | WIN32_CONSOLE usage |
| Previous Message | Bruce Momjian | 2003-09-07 15:40:33 | Re: [PATCHES] MinGW patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2003-09-07 16:16:23 | Re: [HACKERS] Index creation takes for ever |
| Previous Message | Tom Lane | 2003-09-07 15:57:36 | Re: [HACKERS] Index creation takes for ever |