| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] MinGW patch |
| Date: | 2003-09-07 10:03:52 |
| Message-ID: | Pine.LNX.4.44.0309071159370.1172-100000@peter.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-cygwin pgsql-hackers-win32 pgsql-patches |
Bruce Momjian writes:
In mbprint.c:
+ #ifndef PGSCRIPTS
+ #include "settings.h"
+ #endif
Why is this needed, considering that the rest of the code was not changed
to make use of any setting? The print modules in psql should not make use
of psql-specific settings. That's why there are extensive separate
structures to pass this information.
Also, I'm beginning to feel that there are too many places where the lack
of getpwuid() is being worked around. That needs to be centralized.
Lastly, since there is not going to be a Windows port in 7.4, why was this
committed to the head branch?
--
Peter Eisentraut peter_e(at)gmx(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-09-07 13:58:23 | Re: [PATCHES] MinGW patch |
| Previous Message | Peter Eisentraut | 2003-09-07 09:55:51 | Re: [PATCHES] MinGW patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-09-07 13:58:23 | Re: [PATCHES] MinGW patch |
| Previous Message | Peter Eisentraut | 2003-09-07 09:55:51 | Re: [PATCHES] MinGW patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2003-09-07 13:58:23 | Re: [PATCHES] MinGW patch |
| Previous Message | Peter Eisentraut | 2003-09-07 09:55:51 | Re: [PATCHES] MinGW patch |