From: | Alvaro Herrera <alvherre(at)atentus(dot)com> |
---|---|
To: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> |
Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: contrib/ buffer paranoia |
Date: | 2002-08-12 19:22:35 |
Message-ID: | Pine.LNX.4.44.0208121520520.9126-100000@cm-lcon1-46-187.cm.vtr.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Neil Conway dijo:
> Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
> > I think in dbase/dbf2pg.c the limit of 10 to pgdate should be 11
> > (snprintf counts the \0 at the end).
>
> Yes, but so does the array declaration itself: a char[10] can hold at
> most 9 characters plus the '\0' terminator. I think the original code
> is buggy: if the author wants to store 10 characters plus a terminator
> in the array, it should be declared as a char[11]. Using snprintf() of
> length 11 with a char[10] would allow for a one-character overrun.
I agree. Maybe it worked out of pure luck (or some alignment magic).
But while you're at it, you can as well correct the bug.
--
Alvaro Herrera (<alvherre[a]atentus.com>)
"Hay quien adquiere la mala costumbre de ser infeliz" (M. A. Evans)
From | Date | Subject | |
---|---|---|---|
Next Message | Gerhard Hintermayer | 2002-08-12 19:56:22 | Re: [INTERFACES] libpgtcl modifications |
Previous Message | Neil Conway | 2002-08-12 18:51:24 | Re: contrib/ buffer paranoia |