Re: [PATCH] Cleanup of JDBC character encoding

From: Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: <pgsql-jdbc(at)postgresql(dot)org>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCH] Cleanup of JDBC character encoding
Date: 2001-07-13 13:59:13
Message-ID: Pine.LNX.4.33.0107131554370.8398-400000@sensenet.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc pgsql-patches

On Thu, 12 Jul 2001, Bruce Momjian wrote:

> Your patch has been added to the PostgreSQL unapplied patches list at:

Here is a new version of that patch, with improvements from some feedback
I got from Barry Lind.
More of the encoding-related logic is moved into the Encoding class and
I've added som clarifying comments.

/Anders

> > With this patch I've done an attempt to make the handling of character
> > encoding in the JDBC driver a little clearer.
> >
> > * Cleans up the logic to select a JVM encoding for a backend encoding.
> > * Makes the connection setup code easier to read.
> > * Gathers character encoding and decoding in a single place.
> > * Adds unit tests for encoding.
> > * Introduces a new class, org.postgresql.core.Encoding, and the
> > corresponding unit test class, org.postgresql.test.jdbc2.EncodingTest.

_____________________________________________________________________
A n d e r s B e n g t s s o n ndrsbngtssn(at)yahoo(dot)se
Stockholm, Sweden

Attachment Content-Type Size
encoding.patch text/plain 15.7 KB
Encoding.java text/plain 4.5 KB
EncodingTest.java text/plain 1.4 KB

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Tony Grant 2001-07-13 14:09:49 alternative jdbc
Previous Message jason 2001-07-13 13:27:46 DatabaseMetaData.supportsCatalogsInXXX()

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-07-13 14:36:57 Re: [PATCH] Cleanup of JDBC character encoding
Previous Message Mark Volpe 2001-07-13 13:23:57 Re: [HACKERS] [PATCH] Re: Setuid functions