Re: Patch to warn about oid/xid wraparound

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Lamar Owen <lamar(dot)owen(at)wgcr(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to warn about oid/xid wraparound
Date: 2001-06-13 20:35:26
Message-ID: Pine.LNX.4.30.0106132231390.756-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian writes:

> Here is an new patch that updates the percentage display when it is run,
> rather than just displaying 75%. I had to do the computation using
> floats to prevent overflow.

You could use ldiv().

Also, UINT_MAX (for transaction id) and OID_MAX (for Oid) might be
preferred over ~0.

Btw., there is a typo here:

> GetCurrentTransactionId() - (float)(~(TransactionId)0) * 100);

--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2001-06-13 20:55:45 RE: vacuum
Previous Message Vince Vielhaber 2001-06-13 20:20:09 Re: create user problem

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-06-13 21:04:32 Re: [HACKERS] Patch to warn about oid/xid wraparound
Previous Message Bruce Momjian 2001-06-13 19:56:06 Re: Patch to warn about oid/xid wraparound