Re: Remove sort files

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Remove sort files
Date: 2001-05-24 08:35:12
Message-ID: Pine.LNX.4.30.0105241033360.757-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian writes:

> OK, I did the readdir() thing. I hope it is safe to unlink a file while
> in a readdir() loop.

The only portable member of struct dirent is d_name. (Do you really
expect non-regular files in the sort directory?) Also, lots of error
checks (after opendir, readdir, mkdir, unlink) are missing.

--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-05-24 14:26:50 Re: Remove sort files
Previous Message Bruce Momjian 2001-05-24 01:14:32 Re: Remove sort files