Re: Re: [PATCHES] patch for minor Win32 makefile bug

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Fred Yankowski <fred(at)ontosys(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <Jason(dot)Tishler(at)dothill(dot)com>, <pgsql-ports(at)postgresql(dot)org>
Subject: Re: Re: [PATCHES] patch for minor Win32 makefile bug
Date: 2001-04-03 22:16:52
Message-ID: Pine.LNX.4.30.0104040008080.974-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches pgsql-ports

Fred Yankowski writes:

> I don't understand the several uses of DLLLIBS as well as I'd like,
> but here's what I think is going on.
>
> In makefiles/Makefile.win, DLLLIBS lists the libraries needed to build
> the various DLLs associated with the interfaces/* and pl/plpgsql
> directories. As such it includes '-L$(top_builddir)/src/backend -lpostgres'
> as well as several Cygwin utility libraries.
>
> In backend/Makefile, DLLLIBS lists the libraries needed to build
> postgres.exe. This does not include '-lpostgres' since postgres.exe
> is built by linking exactly the backend object files that also go into
> libpostgres.a. (I don't understand this organization.)

ISTM that $(DLLLIBS) in backend/Makefile should be replaced by

$(LDFLAGS) -lcygipc -lcygwin -lkernel32 $(LIBS)

(Presuming that these three libraries are actually needed. Why isn't
every program linked against -lcygwin?)

--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Jason Tishler 2001-04-04 02:38:51 Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous Message Tom Lane 2001-04-03 22:03:45 Re: [PORTS] Re: patch for minor Win32 makefile bug

Browse pgsql-ports by date

  From Date Subject
Next Message Jason Tishler 2001-04-04 02:38:51 Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous Message Tom Lane 2001-04-03 22:03:45 Re: [PORTS] Re: patch for minor Win32 makefile bug