Re: Re: [PATCHES] Fix for ODBC close

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL odbc list <pgsql-odbc(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [PATCHES] Fix for ODBC close
Date: 2001-02-10 17:03:34
Message-ID: Pine.LNX.4.30.0102101800240.775-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-odbc pgsql-patches

Bruce Momjian writes:

> I replaced the 'ld' with 'gcc -Wl', and that prevents the need for the
> crt1.o.
>
> It still requires -lc:
>
> ifneq ($(PORTNAME), bsdi)
> LINK.shared += $(shlib_symbolic)
> else
> LINK.shared = gcc -shared -Wl,-Bsymbolic,-soname,$(soname)
> SHLIB_LINK += -lc
> endif

You can't hardcode "gcc" like that. I've committed some fixes that should
work for you. Please try them out. Also try to build libpq++.

> It seems the -Bsymbolic needs the gcc, while other links are OK with ld.
> We may find this is true on many platforms.

-Bsymbolic requires all symbols in the library to be resolvable at link
time. If you use 'ld' then you will need to provide all the appropriate
files yourself. The compiler driver normally does that automatically.

--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-02-10 17:06:31 Re: Re: pg_ctl default shutdown mode
Previous Message Bruce Momjian 2001-02-10 17:01:23 Re: Re: [PATCHES] Fix for ODBC close

Browse pgsql-odbc by date

  From Date Subject
Next Message Bruce Momjian 2001-02-10 17:17:13 Re: Re: [PATCHES] Fix for ODBC close
Previous Message Bruce Momjian 2001-02-10 17:01:23 Re: Re: [PATCHES] Fix for ODBC close

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-02-10 17:17:13 Re: Re: [PATCHES] Fix for ODBC close
Previous Message Bruce Momjian 2001-02-10 17:01:23 Re: Re: [PATCHES] Fix for ODBC close