Re: [HACKERS] CREATE TEMP TABLE .... ON COMMIT

From: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] CREATE TEMP TABLE .... ON COMMIT
Date: 2002-08-27 14:08:53
Message-ID: Pine.LNX.4.21.0208271752050.11183-102000@linuxworld.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Revised patch is attached.

Passes all regression tests relating to temp tables. (I am getting
regression test issues with privileges.sql, rules.sql, conversion.sql).

Gavin

On Tue, 27 Aug 2002, Bruce Momjian wrote:

>
> Gavin, how are you doing with this. As I remember, the only remaining
> issue was where to store the 'drop on commit' information in the
> backend. If that is all there is, we can come up with a solution.
>
> ---------------------------------------------------------------------------
>
> Gavin Sherry wrote:
> > On Fri, 9 Aug 2002, Tom Lane wrote:
> >
> > > Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > > > template1=# create temp table a (a int) on commit drop;
> > > > ERROR: You must be inside a transaction to use ON COMMIT
> > >
> > > Surely that's only for ON COMMIT DROP, if you intend to offer the
> > > others?
> >
> > I should have provided details of this in the email. SQL99 details the
> > baviour as follows:
> >
> > If TEMPORARY is specified and ON COMMIT is omitted, then ON COMMIT
> > DELETE ROWS is implicit
> >
> > This might give users a bit of a surprise so the effective behaviour is ON
> > COMMIT PRESERVE ROWS.
> >
> > As for your question (and, perhaps, SQL99) I don't seen how it makes any
> > sense to specify ON COMMIT outside of a transaction block.
> >
> > >
> > > regards, tom lane
> > >
> >
> > Gavin
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 5: Have you checked our extensive FAQ?
> >
> > http://www.postgresql.org/users-lounge/docs/faq.html
> >
>
>

Attachment Content-Type Size
temprel-doc2.diff.gz application/x-gzip 1001 bytes
temprel9.diff.gz application/x-gzip 4.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-08-27 14:17:06 Re: REINDEX ALL and CLUSTER ALL
Previous Message D'Arcy J.M. Cain 2002-08-27 13:59:37 Re: MemoryContextAlloc: invalid request size 1934906735

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-08-27 14:23:02 Re: cygwin rename instead of link (7.2.2)
Previous Message Bruce Momjian 2002-08-27 14:08:32 Re: [Fwd: Re: libpgtcl modifications]