Re: WIP patch - INSERT-able log statements

From: Greg Smith <gsmith(at)gregsmith(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: WIP patch - INSERT-able log statements
Date: 2007-02-21 03:59:37
Message-ID: Pine.GSO.4.64.0702202220590.28183@westnet.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Tue, 20 Feb 2007, Tom Lane wrote:

> A smaller problem is that this forces people to incur a gettimeofday
> call for every message logged

I'm stumped trying to think of an application that would require importing
the logs into a database to analyze them, but not need the timestamp.
I'd expect it to be the primary key on the data.

> Is it worth providing a knob to determine the set of columns emitted?

Myself and Guillaume felt that having the format be standardized had
significant value from a downstream application perspective; it would be
nice to know that everyone can work together to write one simple tool
chain to process these things and it would work everywhere. The current
level of log output customization is part of what makes log analysis tools
so much of a pain.

How about this as a simple way to proceed: have the patch include
everything, as Arul already planned. When it's done, do some benchmarking
with it turned on or off. If it really seems like a drag, then consider a
GUC addition to trim it down. Why optimize prematurely? It's not like
this will be on by default. My guess is that the person sophisticated to
analyze their logs probably has an installation that can support the
overhead.

--
* Greg Smith gsmith(at)gregsmith(dot)com http://www.gregsmith.com Baltimore, MD

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-02-21 05:49:11 Re: tsearch in core patch, for inclusion
Previous Message August Zajonc 2007-02-21 03:31:14 Re: New feature request: FlashBack Query

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-02-21 05:49:11 Re: tsearch in core patch, for inclusion
Previous Message Andrew Dunstan 2007-02-21 03:33:03 Re: [pgsql-patches] pltcl/plython fixes for spi_prepare types