Re: patch for contrib/intarray (current CVS)

From: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch for contrib/intarray (current CVS)
Date: 2001-08-03 04:01:59
Message-ID: Pine.GSO.4.33.0108030701220.9844-100000@ra.sai.msu.su
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2 Aug 2001, Tom Lane wrote:

> Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> writes:
> > please apply attached patch to current CVS.
> > 1. Fixed error with empty array ( '{}' ),
> > test data changed to include such data
> > 2. Test a dimension of an array ( we support only one-dimension)
>
> Looks okay in a quick glance, except error message spelling is poor:
>
> ! #define ARRISNULL(x) ( (x) ? ( ( ARR_NDIM(x) == NDIM ) ? ( ( ARRNELEMS( x ) ) ? 0 : 1 ) : ( ( ARR_NDIM(x) ) ? (elog(ERROR,"Array is not one-dimentional: %d dimentions", ARR_NDIM(x)),1) : 1 ) ) : 1 )
>
> Should be "one-dimensional" and "dimensions". Bruce, would you fix that
> when you apply it?

oops :-%

>
> regards, tom lane
>

Regards,
Oleg
_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg(at)sai(dot)msu(dot)su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message RCrowe 2001-08-03 04:26:43 Any hints on how to limit WAL file disk usage?
Previous Message Tom Lane 2001-08-03 03:12:28 Re: TRUNCATE question