Re: Re: equal operator for _int4 (array of int4)

From: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: equal operator for _int4 (array of int4)
Date: 2000-12-21 16:48:50
Message-ID: Pine.GSO.3.96.SK.1001221194304.19999m-100000@ra
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 21 Dec 2000, Tom Lane wrote:

> Date: Thu, 21 Dec 2000 11:32:47 -0500
> From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> To: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
> Cc: pgsql-hackers(at)postgresql(dot)org
> Subject: [HACKERS] Re: equal operator for _int4 (array of int4)
>
> Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> writes:
> > this call produces core when one of the PointerGetDatum(ev0p->pred)
> > or PointerGetDatum(datum) is NULL
> > We use internal postgres function for array comparison -
> > &giststate->equalFn is references to array_eq
>
> array_eq is marked strict, so it's not expecting to get a NULL input.
>
> It's impossible to pass a true SQL NULL through FunctionCall3() anyway
> --- no, a null pointer is not an SQL null. So if you want to use
> a coding convention that equates null pointer with SQL null, you'll
> have to implement that within your own code and avoid calling array_eq
> when you have a null.

ok. one check isn't difficult to add :-)

>
> IIRC, the rtree and/or gist index types are fairly sloppy about this
> point at the moment. I do not like that, because I do not think an
> index type should depend on the assumption that all datatypes it can
> handle are pass-by-reference. If you're going to support nulls then
> there needs to be a separate isnull flag for each datum, *not* an
> assumption that all-zero-bits can't be a valid datum value. But I
> didn't get around to changing the code yet.
>

Tom, this task is too complex for our current understanding of postgres
internals. What will happens if we ignore NULLs ? We need to provide
vacuum some information about numbers of NULL values.

Oleg

> regards, tom lane
>

_____________________________________________________________
Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
Sternberg Astronomical Institute, Moscow University (Russia)
Internet: oleg(at)sai(dot)msu(dot)su, http://www.sai.msu.su/~megera/
phone: +007(095)939-16-83, +007(095)939-23-83

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oliver Elphick 2000-12-21 16:49:29 Re: SSL Connections
Previous Message Tom Lane 2000-12-21 16:32:47 Re: equal operator for _int4 (array of int4)