From: | Kris Jurka <books(at)ejurka(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | pgsql-jdbc(at)postgresql(dot)org |
Subject: | Re: Fast BigDecimal |
Date: | 2009-04-19 05:20:11 |
Message-ID: | Pine.BSO.4.64.0904190118370.28015@leary.csoft.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
On Sat, 18 Apr 2009, Kris Jurka wrote:
> On Thu, 16 Apr 2009, Heikki Linnakangas wrote:
>
>> Here's another patch I put together while trying to improve performance for
>> the customer that bumped into the repeated Describe thing yesterday. It
>> speeds up ResultSet.getBigDecimal() with the same fastpath implementation
>> we have for getInt and getLong.
>
> To maintain the same behavior as the current code, you need to handle the
> period more carefully. You must ensure that there is only one and that
> there's at least one other number. Consider the case of SELECT '.' OR SELECT
> '1.......'.
>
For some reason I thought this would be tricky. We just need to track the
total number for periods seen and error out if > 1 or equal to the total
number of characters. I've done that and committed it.
Kris Jurka
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-04-19 08:16:14 | Re: Fast BigDecimal |
Previous Message | Kris Jurka | 2009-04-18 23:56:20 | Re: Fast BigDecimal |