Re: Remove warning about const qualifier

From: Kris Jurka <books(at)ejurka(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Remove warning about const qualifier
Date: 2007-04-16 19:04:38
Message-ID: Pine.BSO.4.64.0704161459030.14004@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, 16 Apr 2007, Tom Lane wrote:

> Kris Jurka <books(at)ejurka(dot)com> writes:
>> The attached patch removes this warning:
>> encnames.c:511: warning: passing argument 1 of 'clean_encoding_name'
>> discards qualifiers from pointer target type
>
> Applied, but I've not seen that warning myself ... what compiler are
> you using exactly?
>

I was testing a gcc 4.3 snapshot from 3/26/07. It also complains

hba.c:1199: warning: array subscript is below array bounds

Which looks pretty bogus to me. And then the following which may be
valid, but wasn't something I was concerned about at this time.

tuplesort.c: In function 'comparetup_heap':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c: In function 'ApplySortFunction':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c: In function 'comparetup_datum':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c: In function 'comparetup_index':
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here
tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
--param large-stack-frame-growth limit reached
tuplesort.c:2175: warning: called from here

Kris Jurka

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-04-16 19:09:38 Re: Remove warning about const qualifier
Previous Message Tom Lane 2007-04-16 18:51:55 Re: Remove warning about const qualifier