Re: patch adding new regexp functions

On Wed, 21 Mar 2007, Tom Lane wrote:

> Jeremy Drake <pgsql(at)jdrake(dot)com> writes:
> > BTW, should I be calling
> > get_typlenbyvalalign on TEXTOID or are there macros for those also?
>
> By and large we tend to hard-wire those properties too, eg there are
> plenty of places that do things like this:
>
> /* XXX: this hardcodes assumptions about the regtype type */
> result = construct_array(tmp_ary, num_params, REGTYPEOID, 4, true, 'i');
>
> Some are better commented than others ...

So, what action (if any) should be taken? Should all (or some) of these
values be hardcoded, or should the current calls to determine them be left
in place?

>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org
>
>

--
Fortune's Real-Life Courtroom Quote #19:

Q: Doctor, how many autopsies have you performed on dead people?
A: All my autopsies have been performed on dead people.