Re: Patch - Solving compilation problem for Sun

From: Kris Jurka <books(at)ejurka(dot)com>
To: Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM>
Cc: Dave Page <dpage(at)postgresql(dot)org>, pgadmin-hackers(at)postgresql(dot)org, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Subject: Re: Patch - Solving compilation problem for Sun
Date: 2007-01-14 00:37:28
Message-ID: Pine.BSO.4.64.0701131932550.5667@leary2.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Sat, 13 Jan 2007, Dhanaraj M wrote:

>> The patch looks OK in theory (I haven't actually tested it yet), though
>> I would prefer to see the compiler test as a macro in acinclude.m4
>>

The assembly of CXXFLAGS seems backwards. Instead of making g++ specific
flags the default and requiring a special case for each compiler that
doesn't support them, it should only add them if being compiled with g++.

Kris Jurka

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2007-01-15 07:42:46 Roadmap
Previous Message Dhanaraj M 2007-01-13 09:23:36 Re: Patch - Solving compilation problem for Sun studio compiler