Re: Updated high-unicode patch

From: Kris Jurka <books(at)ejurka(dot)com>
To: Oliver Jowett <oliver(at)opencloud(dot)com>
Cc: "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: Updated high-unicode patch
Date: 2005-08-19 05:34:38
Message-ID: Pine.BSO.4.62.0508190021590.11917@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

On Thu, 30 Jun 2005, Oliver Jowett wrote:

> The attached patch is an updated and bugfixed version of my earlier
> patch to support UTF-8 encoding of unicode codepoints above U+FFFF

I'm don't like the cost of the new tests included here. On my 2 x PIII
800 machine the entire JDBC 2 test suite takes 212 seconds. testEncoding
takes 67 seconds testUTF8Decode takes 111 seconds for a whopping 84% of
the test time for 2 out of 220 tests. Do you have any recommendations for
lowering this? Random ideas that I could see:

- using STEP in testUTF8Decode as well to reduce the number of iterations
and adding a BIGSTEP for the high unicode range
- selecting a representative sample of codepoints to test
- creating a separate encoding test suite that is driven by "ant enctest"
- running the tests only occasionally since they don't depend on JVM or
database version and should therefore be pretty static, say randomly
1 out of 10 runs.
- doing nothing 3.5 minutes isn't really all that long

Kris Jurka

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Kris Jurka 2005-08-19 07:03:31 COPY support survey
Previous Message Kris Jurka 2005-08-19 05:03:31 Re: postgresql and java data types mismatch.....